Skip to content

docs(#232): document mint deploy-time source stamping pattern#267

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/232-mint-stamping-docs
Open

docs(#232): document mint deploy-time source stamping pattern#267
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/232-mint-stamping-docs

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown

Add a paragraph to the Mint function section of AGENTS.md documenting that build metadata (version, commit) must use deploy-time source stamping, not runtime environment variables. The provisioner should write a generated source file into the function source zip at bundle time with values baked in, so metadata cannot drift from the deployed code.

This prevents the env-var anti-pattern seen in upstream PR
fullsend-ai#2909, where the code agent chose runtime env vars and a human
had to intervene to switch to source stamping.


Closes #232

Post-script verification

  • Branch is not main/master (agent/232-mint-stamping-docs)
  • Secret scan passed (gitleaks — c776c248ac9a91f10998ca7107e974a6c9d76514..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Add a paragraph to the Mint function section of AGENTS.md
documenting that build metadata (version, commit) must use
deploy-time source stamping, not runtime environment variables.
The provisioner should write a generated source file into the
function source zip at bundle time with values baked in, so
metadata cannot drift from the deployed code.

This prevents the env-var anti-pattern seen in upstream PR
fullsend-ai#2909, where the code agent chose runtime env vars and a human
had to intervene to switch to source stamping.

Closes #232
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 10, 2026

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure · Started 12:57 PM UTC · Completed 12:58 PM UTC
Commit: c776c24 · View workflow run →

@guyoron1

Copy link
Copy Markdown
Owner

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 10, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:57 PM UTC · Completed 4:03 PM UTC
Commit: d8e3df7 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review — ✅ Approve

PR: docs(#232): document mint deploy-time source stamping pattern
Scope: 1 file changed (AGENTS.md), +2 lines

Summary

Clean, well-scoped documentation addition. The paragraph adds prescriptive guidance to the Mint function section of AGENTS.md, directing agents to use deploy-time source stamping (not runtime env vars) for version/commit metadata. This directly addresses the anti-pattern documented in issue #232.

Dimension results

Dimension Result
Correctness ✅ Pass
Security ✅ Pass — no secrets, no injection patterns
Intent & coherence ✅ Pass — authorized by #232, correctly scoped
Style & conventions ✅ Pass — matches existing bold-label format
Docs currency ✅ Pass — no conflicting docs elsewhere
Cross-repo contracts ⏭ Skipped — no APIs/schemas modified

Notes

  • The paragraph uses prescriptive language ("should", "e.g.", "When adding", "Follow this approach for any future build metadata") — this is clearly forward-looking guidance, not a description of current implementation. The existing FULLSEND_SOURCE_HASH env var serves a different purpose (deployment identity/cache-busting) and is not in scope of this guidance.
  • Placement between the "Mint function" sync guidance and "Mint client" section is correct and follows the issue's specification.

Protected paths detected — this PR modifies files under one or more
protected paths. The review agent cannot approve PRs that touch these paths.
A human reviewer must approve this PR.

Protected files in this PR:

  • AGENTS.md

Labels: Documentation-only PR modifying AGENTS.md agent guidance

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment documentation Improvements or additions to documentation labels Jul 10, 2026
@guyoron1

Copy link
Copy Markdown
Owner

/fs-fix

@fullsend-ai-coder

fullsend-ai-coder Bot commented Jul 10, 2026

Copy link
Copy Markdown
Author

🤖 Finished Fix · ✅ Success · Started 5:38 PM UTC · Completed 5:43 PM UTC
Commit: d8e3df7 · View workflow run →

@fullsend-ai-coder

Copy link
Copy Markdown
Author

🔧 Fix agent — iteration 1 (human-triggered)

No changes made. The review agent approved this PR with no findings. The human /fs-fix trigger provided no specific instruction. Nothing to fix.

Disagreed (1):

  1. no actionable findings from review: The most recent review was an approval (✅ Approve) with all dimensions passing and zero findings. The human /fs-fix command provided no specific instruction (HUMAN_INSTRUCTION=none). There are no code changes to make.

Tests: passed

Updated by fullsend fix agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RTK+Ponytail] Document mint version-stamping pattern in AGENTS.md to prevent env-var anti-pattern

1 participant