docs(#239): add ADR-awareness steps to code-implementation skill#278
docs(#239): add ADR-awareness steps to code-implementation skill#278fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add two changes so the code agent checks Architecture Decision Records during planning: 1. Step 3 substep 1: mention checking for an ADR directory (docs/ADRs/, adr/, docs/architecture/decisions/) so the agent knows to consult them later in step 8. 2. Step 8: insert new substep 5 after "Follow cross-repo references" instructing the agent to search ADR files for keywords matching the area being changed. If an ADR constrains the approach, the agent must follow the ADR over ad-hoc issue recommendations. Renumber subsequent substeps (5-9 become 6-10). This prevents wasted code-review-fix cycles when an issue recommended approach conflicts with an accepted ADR. Closes #239
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
|
🤖 Finished Review · ❌ Failure · Started 1:14 PM UTC · Completed 1:14 PM UTC |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 3:57 PM UTC · Completed 4:11 PM UTC |
Review — approvePR: docs(#239): add ADR-awareness steps to code-implementation skill SummaryClean, well-scoped change that adds ADR-awareness to the code-implementation skill's planning phase. The PR implements exactly what issue #239 requested — no more, no less. Dimensions reviewed
Labels: PR modifies agent skill documentation |
|
/fs-fix |
|
🤖 Finished Fix · ✅ Success · Started 5:38 PM UTC · Completed 5:42 PM UTC |
🔧 Fix agent — iteration 1 (human-triggered)No changes made. The review agent approved PR #278 with no findings, and the human /fs-fix command included no instruction text. Nothing to fix. Disagreed (1):
Tests: passed Updated by fullsend fix agent |
Add two changes so the code agent checks Architecture Decision Records during planning:
Step 3 substep 1: mention checking for an ADR directory
(docs/ADRs/, adr/, docs/architecture/decisions/) so the agent
knows to consult them later in step 8.
Step 8: insert new substep 5 after "Follow cross-repo
references" instructing the agent to search ADR files for
keywords matching the area being changed. If an ADR constrains
the approach, the agent must follow the ADR over ad-hoc issue
recommendations. Renumber subsequent substeps (5-9 become
6-10).
This prevents wasted code-review-fix cycles when an issue recommended approach conflicts with an accepted ADR.
Closes #239
Post-script verification
agent/239-adr-awareness-skill)c776c248ac9a91f10998ca7107e974a6c9d76514..HEAD)