docs(#253): add shell-safety heuristics to review correctness#279
docs(#253): add shell-safety heuristics to review correctness#279fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add echo-flag-injection and unquoted-heredoc-expansion
heuristics to the correctness sub-agent and the code-review
skill. Both rules are scoped to harness scripts
(post-code.sh, post-fix.sh, post-review.sh) where user- or
agent-controlled content flows through shell commands.
Echo flag injection: echo "${VAR}" interprets leading
dashes as flags, silently corrupting output. Recommends
printf. Unquoted heredoc: <<TOKEN allows shell expansion of
$ and backticks in structured data, silently corrupting
JSON/YAML. Recommends jq -n or quoted heredocs.
False-positive scoping: neither rule fires on hardcoded
strings, quoted heredocs, or non-harness scripts.
Closes #253
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
|
🤖 Finished Review · ❌ Failure · Started 1:15 PM UTC · Completed 1:15 PM UTC |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 3:57 PM UTC · Completed 4:08 PM UTC |
|
Looks good to me Labels: PR adds shell-safety heuristics to review agent skill documentation |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
|
/fs-fix |
|
🤖 Finished Fix · ✅ Success · Started 5:38 PM UTC · Completed 5:42 PM UTC |
🔧 Fix agent — iteration 1 (human-triggered)No changes made. The review agent approved the PR with no findings, and the human /fs-fix command provided no specific instruction. Nothing to fix. Disagreed (1):
Tests: passed Updated by fullsend fix agent |
1 participant
Add echo-flag-injection and unquoted-heredoc-expansion heuristics to the correctness sub-agent and the code-review skill. Both rules are scoped to harness scripts (post-code.sh, post-fix.sh, post-review.sh) where user- or agent-controlled content flows through shell commands.
Echo flag injection: echo "${VAR}" interprets leading dashes as flags, silently corrupting output. Recommends printf. Unquoted heredoc: <<TOKEN allows shell expansion of $ and backticks in structured data, silently corrupting JSON/YAML. Recommends jq -n or quoted heredocs.
False-positive scoping: neither rule fires on hardcoded strings, quoted heredocs, or non-harness scripts.
Closes #253
Post-script verification
agent/253-shell-safety-heuristics)c776c248ac9a91f10998ca7107e974a6c9d76514..HEAD)