Open
Conversation
* feat: fix Docker Compose for local development and add setup tooling Agent-Logs-Url: https://github.com/abc-cluster/brims/sessions/68db3f68-eab6-4b7b-b09f-9b3c66e3ecbc Co-authored-by: abhi18av <12799326+abhi18av@users.noreply.github.com> * fix: address code review feedback on Docker setup Agent-Logs-Url: https://github.com/abc-cluster/brims/sessions/68db3f68-eab6-4b7b-b09f-9b3c66e3ecbc Co-authored-by: abhi18av <12799326+abhi18av@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: abhi18av <12799326+abhi18av@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @gvds ,
I think that with this PR, the application should work well as far as local setup with seed is concerned. I'd appreciate your critical review to make sure these changes do not break any existing functionality.
This pull request introduces a complete, ready-to-use Docker-based local development environment for the BRIMS application, along with improvements to database seeding and factory reliability. The new Docker setup provides a streamlined workflow for developers, including scripts, configuration files, and documentation updates. Additionally, several changes make database factories and seeders more robust, reducing collisions and ensuring test data is seeded correctly.
Docker Local Development Environment
.env.dockerwith sensible defaults for local development, and updated documentation inREADME.mdandDEPLOYMENT.mdto provide clear setup instructions. [1] [2] [3]docker-compose.ymlthat orchestrates PHP 8.4, MariaDB 11, Mailpit, and phpMyAdmin, with improved environment variable handling and service health checks. [1] [2]docker/8.5/Dockerfile) for a slimmer, faster build using PHP 8.4, and simplified dependency installation.docker/8.5/start-containerto ensure Composer dependencies are installed before services start, preventing race conditions.docker/8.5/supervisord.conf) to manage the queue worker and scheduler automatically in the container.docker/mariadb/create-testing-database.shfor correct permissions.Database Factories and Seeders Reliability
AssayDefinitionFactory,ProjectFactory, andStudyFactoryto generate unique values and always associate records with valid teams and users, reducing collisions and errors during large seed runs. [1] [2] [3] [4] [5]AssayDefinitionSeederandProjectSeederto more reliably assign users and leaders to teams and projects, ensuring referential integrity during seeding. [1] [2] [3]These changes together provide a much smoother onboarding and development experience for contributors, and make automated testing and local development more reliable.