Conversation
… query execution and enhance rollback/commit behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the unit tests for connection transaction handling to better reflect the intended no-op behavior when there is no active transaction. The tests for committing and rolling back without a transaction are simplified and no longer expect the underlying connection methods to be called.
Test improvements for transaction handling:
test_commit_without_transactionandtest_rollback_without_transactionto verify that commit and rollback are no-ops when there is no active transaction, removing unnecessary mocks and assertions about underlying connection calls. [1] [2]… query execution and enhance rollback/commit behavior