Emulate terminal dim as a muted gray instead of dropping it#657
Merged
Conversation
Dropping dim entirely (so unreadable muted text became legible) made the input ghost/placeholder suggestion render at full intensity, looking like already-typed input. Dim over the default foreground is now substituted with an explicit muted gray (dark rgb(112,120,150), light rgb(130,130,130)): readable yet clearly secondary. The dim is resolved at SGR sequence end and emulated only when no explicit fg accompanies it (a color still wins); reset by SGR 0 and SGR 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rgb(112,120,150), lightrgb(130,130,130)) — readable yet clearly secondary, so placeholder/ghost text, select-prompt descriptions, recap and hints all read correctly in both themes.Verified live in the dark theme. Covered by updated unit tests in
ansi-theme-adapt.test.ts; module doc comment and decision record 066 updated.