Fix file-lock double-acquire in ENOENT recovery branch#660
Merged
Conversation
The ENOENT branch recovered with mkdirSync(lockDir, { recursive: true }),
which never throws EEXIST and succeeds on an already-existing dir. Two
processes racing through this branch for a brand-new project could both
acquire the same lock and corrupt tasks.json. Create only the parent dir
and retry the atomic non-recursive mkdir so EEXIST detection holds. Lock
path and on-disk shape are unchanged (older versions stay interoperable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/bun/file-lock.ts) could be acquired by two processes at once for a brand-new project. The ENOENT recovery branch usedmkdirSync(lockDir, { recursive: true }), which is idempotent and never throws EEXIST — so two processes racing through that branch (e.g. desktop app +dev3 remotedoing the first write for a new project) could both "acquire" the same lock and corrupttasks.jsonvia lost updates.mkdirSync(lockDir). EEXIST detection is preserved, so exactly one process wins.<filePath>.lock) and its plain-empty-directory shape are unchanged, so older app versions sharing~/.dev3.0/keep interoperating and a downgrade is safe.file-lock-enoent-race.test.ts, mocksnode:fsto inject a single ENOENT while the lock dir already exists) plus backward-compatibility tests asserting the lock dir is a plain dir acquirable/removable via plainmkdir/rmdir.069.(This PR was prepared by Claude, the AI assistant working on this branch.)