fix: read .templatesyncignore from template remote in GitLab sync#17
Merged
fix: read .templatesyncignore from template remote in GitLab sync#17
Conversation
The sync script was reading the local .templatesyncignore to build the include list. When the template adds new files and updates .templatesyncignore in the same commit, the local copy doesn't include the new entries yet, so the new files are never copied. Read from template/main:.templatesyncignore instead, falling back to the local copy if unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.templatesyncignoreを読んでいたため、テンプレート側で新ファイル追加と.templatesyncignore更新が同時に行われた場合、新ファイルが sync MR に含まれなかったgit show template/main:.templatesyncignoreでテンプレート側のホワイトリストを読むように修正Root Cause
sync-template.ymlの include リスト構築がローカルの.templatesyncignoreに依存していた。テンプレートで同時に追加された新ファイルはリストに含まれず、.templatesyncignoreだけが更新される不整合な MR が生成されていた。Test plan
templatesyncignore_checkが通ることを確認