Remove redundant paragonie/sodium_compat dependency#1
Open
brendt wants to merge 29 commits into
Open
Conversation
Add return 1 to satisfy @return int from the abstract class
Add return 1 to satisfy @return int from the abstract class
Add return 1 to satisfy @return int from the abstract class
Return int from the commands to satisfy Symfony\Component\Console\Command execute @return int
Upgrade PHPUnit to 8+ and allow the package to be installed with PHP 8.0
fix IterableResult deprecated
Author
|
Not sure why all these changes end up in my PR… anyway, feel free to cherry pick if you decide you want the contibution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package depends on
paragonie/sodium_compat: ^1.5, but alsophp: ^7.2. Sincelibsodiumwas added in PHP 7.2, the dependency onparagonie/sodium_compatseems redundant?