Update bootloader options to allow for adafruit stock bootloaders #82
+11,380
−11,099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h2zero
force-pushed
the
update-linker/bootloaders
branch
4 times, most recently
from
a5faa15 to
91baaee
Compare
h2zero
changed the title
h2zero
force-pushed
the
update-linker/bootloaders
branch
from
50d9afe to
6d96e2a
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates bootloader configuration to support Adafruit stock bootloaders by removing embedded bootloader hex files and updating linker scripts to use calculated memory layouts instead of hardcoded values. The changes standardize flash memory region calculations across variants and add new linker scripts for S140 v6 and v7 softdevice configurations with Adafruit bootloader support.
Changes:
- Removes embedded bootloader hex files from two variant directories
- Updates existing linker scripts to use arithmetic expressions for flash memory length calculations
- Adds new linker scripts for nRF52840 and nRF52833 with S140 v6/v7 softdevice and Adafruit bootloader
Reviewed changes
Copilot reviewed 13 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| variants/itsybitsy_nrf52840_express/ada_bootloader.hex | Removed embedded bootloader (2378 lines) |
| variants/BT5032A_TB/ada_bootloader.hex | Removed embedded bootloader (1573 lines) |
| cores/nRF5/nordic/linker/nrf52840_xxaa.ld | Changed flash length to use calculation: 0x100000 - 0x4000 |
| cores/nRF5/nordic/linker/nrf52840_serial_adabl.ld | Changed flash length to: 0xF4000 - 0x1000 - 0x4000 |
| cores/nRF5/nordic/linker/nrf52840_s140_v7_adabl.ld | New linker script for S140 v7 with Adafruit bootloader |
| cores/nRF5/nordic/linker/nrf52840_s140_v6_adabl.ld | New linker script for S140 v6 with Adafruit bootloader |
| cores/nRF5/nordic/linker/nrf52833_xxaa.ld | Changed flash length to: 0x80000 - 0x4000 |
| cores/nRF5/nordic/linker/nrf52833_serial_adabl.ld | Changed flash length to: 0x74000 - 0x1000 - 0x4000 |
| cores/nRF5/nordic/linker/nrf52833_s140_v7_adabl.ld | New linker script for nRF52833 with S140 v7 and Adafruit bootloader |
| cores/nRF5/nordic/linker/nrf52832_xxaa.ld | Changed flash length to: 0x80000 - 0x4000 |
| cores/nRF5/nordic/linker/nrf52832_serial_adabl.ld | Changed flash length to: 0x74000 - 0x1000 - 0x4000 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
h2zero
force-pushed
the
update-linker/bootloaders
branch
from
6d96e2a to
9b857e6
Compare
h2zero
force-pushed
the
update-linker/bootloaders
branch
2 times, most recently
from
36ea77f to
bb6965b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.