fix: handle Windows charmap encoding errors for Unicode data#2
Open
theKorzh wants to merge 1 commit intoh3lix1:mainfrom
Open
fix: handle Windows charmap encoding errors for Unicode data#2theKorzh wants to merge 1 commit intoh3lix1:mainfrom
theKorzh wants to merge 1 commit intoh3lix1:mainfrom
Conversation
Fixes h3lix1#1 On Windows, the default 'charmap' codec may fail to encode certain Unicode characters (e.g. \u95f0), causing exceptions when processing text data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Problem
On Windows, the default 'charmap' codec may fail to encode certain Unicode
characters (e.g. \u95f0), causing exceptions when writing HTML output.
This was observed not only with sample data but also in other cases involving
non-ASCII content.
Solution
Explicitly set UTF-8 encoding when creating temporary HTML files.
Result
Tested on Windows 10 / Python 3.12