Skip to content

feat: migrate to hcaptcha-loader#144

Draft
CAMOBAP wants to merge 6 commits into
mainfrom
feature/migrate-to-hcaptcha-loader
Draft

feat: migrate to hcaptcha-loader#144
CAMOBAP wants to merge 6 commits into
mainfrom
feature/migrate-to-hcaptcha-loader

Conversation

@CAMOBAP

@CAMOBAP CAMOBAP commented Jan 26, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@CAMOBAP CAMOBAP requested review from DSergiu and e271828- January 26, 2024 12:38
@CAMOBAP CAMOBAP self-assigned this Jan 26, 2024
@github-actions

github-actions Bot commented Jan 26, 2024

Copy link
Copy Markdown

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff       
──────────┼───────────┼───────────┼────────────
      jar │  51.7 KiB │  52.7 KiB │     +947 B 
 manifest │     411 B │     411 B │        0 B 
      res │  78.3 KiB │  78.3 KiB │        0 B 
    other │     954 B │     954 B │        0 B 
──────────┼───────────┼───────────┼────────────
    total │ 131.3 KiB │ 304.6 KiB │ +173.3 KiB 

 JAR     │ old │ new │ diff         
─────────┼─────┼─────┼──────────────
 classes │  37 │  37 │   0 (+0 -0)  
 methods │ 507 │ 517 │ +10 (+12 -2) 
  fields │ 162 │ 164 │  +2 (+2 -0)
AAR
 size      │ diff       │ path                           
───────────┼────────────┼────────────────────────────────
 126.2 KiB │ +126.2 KiB │ + assets/hcaptcha/loader.js    
  46.2 KiB │  +46.2 KiB │ + assets/hcaptcha/polyfills.js 
       0 B │        0 B │ + assets/hcaptcha/             
       0 B │        0 B │ + assets/                      
  52.7 KiB │     +947 B │ ∆ classes.jar                  
───────────┼────────────┼────────────────────────────────
   225 KiB │ +173.3 KiB │ (total)
JAR
METHODS:

   old │ new │ diff         
  ─────┼─────┼──────────────
   507 │ 517 │ +10 (+12 -2) 
  
  + com.hcaptcha.sdk.HCaptchaWebViewHelper access_100(HCaptchaWebViewHelper) → HCaptchaConfig
  + com.hcaptcha.sdk.HCaptchaWebViewHelper access_200(HCaptchaWebViewHelper) → HCaptchaWebView
  + com.hcaptcha.sdk.HCaptchaWebViewHelper access_300(HCaptchaWebViewHelper) → IHCaptchaVerifier
  + android.content.Context getAssets() → AssetManager
  + android.content.res.AssetManager open(String) → InputStream
  + android.net.Uri parse(String) → Uri
  + android.view.View getContext() → Context
  + android.webkit.WebResourceResponse <init>(String, String, int, String, Map, InputStream)
  + java.util.Collections singletonMap(Object, Object) → Map
  + java.util.Map get(Object) → Object
  + java.util.Map put(Object, Object) → Object
  + java.util.Objects toString(Object, String) → String
  
  - com.hcaptcha.sdk.HCaptchaWebViewHelper access_100(HCaptchaWebViewHelper) → HCaptchaWebView
  - com.hcaptcha.sdk.HCaptchaWebViewHelper access_200(HCaptchaWebViewHelper) → IHCaptchaVerifier
  

FIELDS:

   old │ new │ diff       
  ─────┼─────┼────────────
   162 │ 164 │ +2 (+2 -0) 
  
  + com.hcaptcha.sdk.BuildConfig LOADER_VERSION: String
  + com.hcaptcha.sdk.HCaptchaWebViewHelper_HCaptchaWebClient assetsCache: Map

@github-actions

github-actions Bot commented Jan 26, 2024

Copy link
Copy Markdown

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +336.35 -6
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +394.48 +106
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup -0.26 +102
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +10.01 +556
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +54.75 +1
com.hcaptcha.sdk.HCaptchaWebViewHelperTest.EMULATOR_UNLOCKED_benchmarkWebViewLoad +641.99 +85

@e271828-

e271828- commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

Waiting for next release of loader with less bloated sentry.

Comment thread sdk/src/main/html/hcaptcha.html Outdated
Comment thread sdk/src/main/html/hcaptcha.html Outdated
@e271828- e271828- marked this pull request as draft January 29, 2024 13:24
@CAMOBAP CAMOBAP requested a review from DSergiu February 29, 2024 21:30
@CAMOBAP CAMOBAP marked this pull request as ready for review February 29, 2024 21:31
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@CAMOBAP CAMOBAP force-pushed the feature/migrate-to-hcaptcha-loader branch from 9b897b9 to 7f421f0 Compare June 26, 2024 20:46
@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2024

Copy link
Copy Markdown

@CAMOBAP CAMOBAP marked this pull request as draft July 5, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants