Skip to content

Fix empty verify params bridge data#257

Merged
e271828- merged 1 commit into
mainfrom
codex/fix-empty-verify-params-setdata
May 1, 2026
Merged

Fix empty verify params bridge data#257
e271828- merged 1 commit into
mainfrom
codex/fix-empty-verify-params-setdata

Conversation

@e271828-

@e271828- e271828- commented May 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • skip hcaptcha.setData when verify params are null or empty
  • preserve config.rqdata fallback behavior
  • update unit and instrumentation expectations for the null-params path

Testing

  • ./gradlew :sdk:testDebugUnitTest --tests com.hcaptcha.sdk.HCaptchaWebViewHelperTest
  • ./gradlew :sdk:check
  • ./gradlew :test:compileDebugAndroidTestJavaWithJavac
  • pre-commit hook: ./gradlew check

@e271828- e271828- mentioned this pull request May 1, 2026
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────
      jar │  94.7 KiB │  94.7 KiB │ +33 B 
 manifest │     411 B │     411 B │   0 B 
      res │  28.3 KiB │  28.3 KiB │   0 B 
    other │     1 KiB │     1 KiB │   0 B 
──────────┼───────────┼───────────┼───────
    total │ 124.4 KiB │ 124.4 KiB │ +33 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  61 │  61 │ 0 (+0 -0) 
 methods │ 800 │ 800 │ 0 (+0 -0) 
  fields │ 270 │ 270 │ 0 (+0 -0)
AAR
 size     │ diff  │ path          
──────────┼───────┼───────────────
 94.7 KiB │ +33 B │ ∆ classes.jar 
──────────┼───────┼───────────────
 94.7 KiB │ +33 B │ (total)

@e271828- e271828- requested review from CAMOBAP and DSergiu May 1, 2026 13:39
@e271828- e271828- force-pushed the codex/fix-empty-verify-params-setdata branch from 09cf021 to cd4d93a Compare May 1, 2026 13:57
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +338.32 +27
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +357.46 +551
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup -4.17 +514
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo -20.29 -5555
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +20.18 +2

@e271828- e271828- merged commit 3d191ff into main May 1, 2026
23 of 24 checks passed
@e271828- e271828- deleted the codex/fix-empty-verify-params-setdata branch May 1, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants