Skip to content

feat(sdk): handle WebView permission requests#264

Merged
Mourtadah-Karim-IMI merged 1 commit into
mainfrom
feat/eng-5947-android-camera-permission
Jun 23, 2026
Merged

feat(sdk): handle WebView permission requests#264
Mourtadah-Karim-IMI merged 1 commit into
mainfrom
feat/eng-5947-android-camera-permission

Conversation

@Mourtadah-Karim-IMI

@Mourtadah-Karim-IMI Mourtadah-Karim-IMI commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Handles additional WebView permission requests.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────
      jar │  94.9 KiB │  95.4 KiB │ +549 B 
 manifest │     411 B │     411 B │    0 B 
      res │  28.3 KiB │  28.3 KiB │    0 B 
    other │     1 KiB │     1 KiB │    0 B 
──────────┼───────────┼───────────┼────────
    total │ 124.6 KiB │ 125.1 KiB │ +549 B 

 JAR     │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  61 │  61 │  0 (+0 -0) 
 methods │ 800 │ 805 │ +5 (+5 -0) 
  fields │ 272 │ 272 │  0 (+0 -0)
AAR
 size     │ diff   │ path          
──────────┼────────┼───────────────
 95.4 KiB │ +549 B │ ∆ classes.jar 
──────────┼────────┼───────────────
 95.4 KiB │ +549 B │ (total)
JAR
METHODS:

   old │ new │ diff       
  ─────┼─────┼────────────
   800 │ 805 │ +5 (+5 -0) 
  
  + com.hcaptcha.sdk.HCaptchaWebViewHelper_HCaptchaWebChromeClient onPermissionRequest(PermissionRequest)
  + android.webkit.PermissionRequest deny()
  + android.webkit.PermissionRequest getResources() → String[]
  + android.webkit.PermissionRequest grant(String[])
  + android.webkit.WebSettings setMediaPlaybackRequiresUserGesture(boolean)

@Mourtadah-Karim-IMI Mourtadah-Karim-IMI requested review from a team, CAMOBAP and DSergiu June 19, 2026 16:00
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +920.35 +26
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +1208.08 +548
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup +22.59 +515.50
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo +96.81 -5537
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +158.79 +2

Comment thread sdk/src/main/java/com/hcaptcha/sdk/HCaptchaWebViewHelper.java Outdated
Comment thread README.md Outdated
@Mourtadah-Karim-IMI Mourtadah-Karim-IMI changed the title feat(sdk): grant WebView camera permission for liveness challenge feat(sdk): handle WebView permission requests Jun 22, 2026
@Mourtadah-Karim-IMI Mourtadah-Karim-IMI force-pushed the feat/eng-5947-android-camera-permission branch from 887887e to 49a365d Compare June 22, 2026 15:03
@Mourtadah-Karim-IMI Mourtadah-Karim-IMI marked this pull request as ready for review June 22, 2026 16:17

@CAMOBAP CAMOBAP left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think some code comments can be removed because code is self-explanatory already

@Mourtadah-Karim-IMI Mourtadah-Karim-IMI merged commit 1ba6c12 into main Jun 23, 2026
12 checks passed
@Mourtadah-Karim-IMI Mourtadah-Karim-IMI deleted the feat/eng-5947-android-camera-permission branch June 23, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants