Skip to content

[codex] Add workflow concurrency controls#17

Merged
ethanolivertroy merged 1 commit into
mainfrom
codex/workflow-concurrency
May 14, 2026
Merged

[codex] Add workflow concurrency controls#17
ethanolivertroy merged 1 commit into
mainfrom
codex/workflow-concurrency

Conversation

@ethanolivertroy
Copy link
Copy Markdown
Member

Summary

  • add a concurrency group to the long-running Update NIST CMVP Data workflow so newer runs for the same ref cancel older in-progress runs
  • keep Validate running on PRs and main pushes, but stop running the same validation twice for codex/** branch pushes
  • add validation workflow concurrency keyed by PR number or ref so outdated validation runs are canceled

Why

After merging the API validation/provenance PR, multiple full data-update workflows were still running on main at the same time. The live scrape can take a long time, so stacking redundant runs wastes Actions time and can produce confusing publish races.

Validation

  • python3 validate_api.py
  • git diff --check

This is workflow-only; the existing PR validation workflow will run after PR creation.

@ethanolivertroy ethanolivertroy marked this pull request as ready for review May 14, 2026 05:09
@ethanolivertroy ethanolivertroy merged commit 05dcf09 into main May 14, 2026
1 check passed
@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Add workflow concurrency controls to prevent redundant runs

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add concurrency controls to update-data.yml workflow to cancel redundant runs
• Remove codex/** branch from validate.yml to prevent duplicate validation
• Implement concurrency groups keyed by ref/PR number for both workflows
Diagram
flowchart LR
  A["update-data.yml"] -->|"Add concurrency group"| B["Cancel in-progress runs"]
  C["validate.yml"] -->|"Remove codex/** branch"| D["Stop duplicate validation"]
  C -->|"Add concurrency group"| B
Loading

Grey Divider

File Changes

1. .github/workflows/update-data.yml ⚙️ Configuration changes +4/-0

Add concurrency controls to update workflow

• Add concurrency group update-nist-cmvp-data-${{ github.ref }} to cancel older runs
• Enable cancel-in-progress: true to stop redundant data update workflows
• Prevents multiple simultaneous scrape operations on the same ref

.github/workflows/update-data.yml


2. .github/workflows/validate.yml ⚙️ Configuration changes +4/-1

Add concurrency and remove duplicate branch trigger

• Remove codex/** branch trigger to prevent duplicate validation runs
• Add concurrency group validate-${{ github.event.pull_request.number || github.ref }}
• Enable cancel-in-progress: true to cancel outdated validation runs
• Validation now runs only on PRs and main branch pushes

.github/workflows/validate.yml


Grey Divider

Qodo Logo

@ethanolivertroy ethanolivertroy deleted the codex/workflow-concurrency branch May 14, 2026 05:09
@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented May 14, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant