Skip to content

fix: fixed the supervisor_enrolment in update projects where it only … #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vocalfreak merged 1 commit into from
Jun 17, 2026
Merged

fix: fixed the supervisor_enrolment in update projects where it only … #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/controllers/projects_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,13 +316,15 @@ def update
if topic
raise StandardError, 'Topic has no valid owner' unless topic.owner.is_a?(User)

supervisor_enrolment = Enrolment.find_by(user_id: topic.owner.id, course_id: @course.id, role: %i[lecturer coordinator])
# DO NOT FIND BY COORDINATOR_ENROLMENT_IDS
supervisor_enrolment = Enrolment.find_by(user_id: topic.owner.id, course_id: @course.id, role: :lecturer)

raise StandardError, 'Could not find supervisor enrolment' unless supervisor_enrolment

@instance.update!(source_topic: topic, supervisor_enrolment: supervisor_enrolment)
else
supervisor_enrolment = Enrolment.find_by(id: lecturer_id, course_id: @course.id, role: %i[lecturer coordinator])
# DO NOT FIND BY COORDINATOR_ENROLMENT_IDS
supervisor_enrolment = Enrolment.find_by(id: lecturer_id, course_id: @course.id, role: :lecturer)

raise StandardError, 'Could not find supervisor enrolment' unless supervisor_enrolment

Expand Down
Loading