🛡️ Sentinel: Fix path traversal in LocalJsonStore#190
Conversation
- Prevent path traversal by rejecting '.' and '..' segments in storage keys. - Ensure resolved paths remain within the base directory using path.relative. - Add security unit tests for LocalJsonStore. - Record critical learning in the security journal. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability:
LocalJsonStoreallowed writing files outside thebaseDirectoryusing..in the key.🎯 Impact: An attacker or a malfunctioning agent could write or overwrite arbitrary JSON files on the filesystem, potentially leading to privilege escalation or data corruption.
🔧 Fix:
.or...path.relativeon the resolved absolute path to ensure it remains within thebaseDirectory, preventing directory prefix bypass.✅ Verification:
packages/documents/src/security.test.tswith test cases for various traversal patterns.PR created automatically by Jules for task 11786367332641928151 started by @hackerxj2010