🛡️ Sentinel: [CRITICAL] Fix path traversal in LocalJsonStore#198
🛡️ Sentinel: [CRITICAL] Fix path traversal in LocalJsonStore#198hackerxj2010 wants to merge 1 commit into
Conversation
This commit secures the `LocalJsonStore` against path traversal vulnerabilities. Previously, malicious keys containing `..` segments could be used to read or write files outside the intended base directory. Changes: - Modified `LocalJsonStore.toPath` to filter out `.` and `..` segments. - Added path resolution and validation using `startsWith` to ensure the final path remains within the base directory. - Added a security test suite in `packages/documents/src/security.test.ts` to verify the fix and prevent regressions. 🚨 Severity: CRITICAL 💡 Vulnerability: Path Traversal 🎯 Impact: Unauthorized file read/write access outside the store directory. ✅ Verification: Ran `pnpm exec vitest run packages/documents/src/security.test.ts`. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
I have identified and fixed a critical path traversal vulnerability in the
LocalJsonStoreclass. By filtering out navigation segments and validating the resolved path against the base directory, the store now correctly restricts file operations to its intended scope. I've also added a dedicated security test suite to verify this behavior.PR created automatically by Jules for task 7770720055113128360 started by @hackerxj2010