π‘οΈ Sentinel: [HIGH] Fix Path Traversal in LocalJsonStore#201
π‘οΈ Sentinel: [HIGH] Fix Path Traversal in LocalJsonStore#201hackerxj2010 wants to merge 1 commit into
Conversation
- Filter out '.' and '..' segments from store keys. - Support cross-platform path separators in keys. - Validate resolved path against base directory with prefix protection. - Add comprehensive security test suite. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Path Traversal in
LocalJsonStoreπ― Impact: An attacker could read, write, or delete arbitrary JSON files outside the intended base directory by using
..segments in the store key.π§ Fix:
.and..segments from the key./and\as path separators for cross-platform robustness.path.resolveand astartsWithcheck with a trailing separator to prevent prefix bypass attacks.β Verification:
packages/documents/src/security.test.tswhich covers read, write, and delete traversal attempts.pnpm exec vitest run packages/documents/src/security.test.ts.pnpm testto ensure no regressions.PR created automatically by Jules for task 10957113255016934380 started by @hackerxj2010