Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix Path Traversal in LocalJsonStore#201

Draft
hackerxj2010 wants to merge 1 commit into
mainfrom
sentinel/fix-path-traversal-10957113255016934380
Draft

πŸ›‘οΈ Sentinel: [HIGH] Fix Path Traversal in LocalJsonStore#201
hackerxj2010 wants to merge 1 commit into
mainfrom
sentinel/fix-path-traversal-10957113255016934380

Conversation

@hackerxj2010
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Path Traversal in LocalJsonStore
🎯 Impact: An attacker could read, write, or delete arbitrary JSON files outside the intended base directory by using .. segments in the store key.
πŸ”§ Fix:

  • Filter out . and .. segments from the key.
  • Support both / and \ as path separators for cross-platform robustness.
  • Validate the resolved path against the base directory using path.resolve and a startsWith check with a trailing separator to prevent prefix bypass attacks.
    βœ… Verification:
  • Created a new security test suite packages/documents/src/security.test.ts which covers read, write, and delete traversal attempts.
  • Verified that all tests pass using pnpm exec vitest run packages/documents/src/security.test.ts.
  • Ran the full monorepo test suite with pnpm test to ensure no regressions.

PR created automatically by Jules for task 10957113255016934380 started by @hackerxj2010

- Filter out '.' and '..' segments from store keys.
- Support cross-platform path separators in keys.
- Validate resolved path against base directory with prefix protection.
- Add comprehensive security test suite.

Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant