🛡️ Sentinel: Fix path traversal in LocalJsonStore#205
Conversation
- Prevent directory traversal by filtering `.` and `..` segments from keys. - Disallow absolute paths in keys. - Validate that the final resolved path is strictly within the `baseDirectory` using a trailing separator check. - Add `packages/documents/src/security.test.ts` to verify the fix. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🛡️ Severity: HIGH
💡 Vulnerability: Path Traversal in
LocalJsonStore🎯 Impact: Attackers could potentially read or write files outside the intended storage directory by using
..segments or absolute paths in store keys.🔧 Fix: Implemented robust path validation in
toPathmethod. It now filters out traversal segments, blocks absolute paths, and performs a strict prefix check on the resolved absolute path.✅ Verification: Created a new security test suite in
packages/documents/src/security.test.tscovering relative traversal, absolute path traversal, and legitimate deep-nested access. All tests pass.PR created automatically by Jules for task 8520179320708303453 started by @hackerxj2010