Improve Interactive Shell and Harden Security#206
Conversation
- Refactor Python CLI shell into a robust InteractiveShell class - Add plan-approval flow and real-time step progress visualization - Harden internal request validation with timing-safe comparisons - Enhance secret redaction for Anthropic, GitHub, AWS, and quoted passwords - Add unit tests for secret redaction logic Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR significantly improves the Jeanbot interactive experience and security posture.
Key changes:
assertInternalRequestin@jeanbot/platformnow uses constant-time comparison viacrypto.timingSafeEqualand SHA-256 hashing to prevent timing attacks.redactSecretsin@jeanbot/securityhas been expanded to cover Anthropic keys, GitHub tokens, AWS access keys, and generic password fields (supporting quoted and unquoted values).packages/security/src/redact.test.tsto verify the redaction logic.These changes bring Jeanbot closer to the interactive and secure experience provided by tools like Claude Code.
PR created automatically by Jules for task 11508913986382430769 started by @hackerxj2010