Skip to content

πŸ›‘οΈ Sentinel: Fix path traversal in LocalJsonStore#209

Draft
hackerxj2010 wants to merge 1 commit into
mainfrom
sentinel/fix-path-traversal-localjsonstore-6235994778132024140
Draft

πŸ›‘οΈ Sentinel: Fix path traversal in LocalJsonStore#209
hackerxj2010 wants to merge 1 commit into
mainfrom
sentinel/fix-path-traversal-localjsonstore-6235994778132024140

Conversation

@hackerxj2010
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Path traversal in LocalJsonStore
🎯 Impact: Attackers could read or write arbitrary JSON files on the filesystem outside the intended base directory.
πŸ”§ Fix: Implemented multiple layers of protection:

  1. Disallow absolute paths in keys.
  2. Filter out . and .. segments.
  3. Resolve the final path and verify it starts with the baseDirectory (using a trailing separator to prevent prefix bypass).
    βœ… Verification: Added packages/documents/src/security.test.ts which confirms that traversal attempts are blocked.

PR created automatically by Jules for task 6235994778132024140 started by @hackerxj2010

- Prevent absolute paths in keys
- Filter out '.' and '..' segments
- Verify resolved path is within baseDirectory
- Add security test suite to verify fix

Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant