π‘οΈ Sentinel: Fix path traversal in LocalJsonStore#209
Conversation
- Prevent absolute paths in keys - Filter out '.' and '..' segments - Verify resolved path is within baseDirectory - Add security test suite to verify fix Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Path traversal in LocalJsonStore
π― Impact: Attackers could read or write arbitrary JSON files on the filesystem outside the intended base directory.
π§ Fix: Implemented multiple layers of protection:
.and..segments.baseDirectory(using a trailing separator to prevent prefix bypass).β Verification: Added
packages/documents/src/security.test.tswhich confirms that traversal attempts are blocked.PR created automatically by Jules for task 6235994778132024140 started by @hackerxj2010