Skip to content

⚡ Bolt: optimize rate limiter Redis pipeline #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hackerxj2010 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: optimize rate limiter Redis pipeline #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .jules/bolt.md
View file
Open in desktop
Empty file.
10 changes: 6 additions & 4 deletions packages/cache/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,17 +132,21 @@ export class SlidingWindowRateLimiter {
const member = `${now}:${crypto.randomUUID()}`;
const cutoff = now - limit.windowMs;

// ⚡ Bolt: Consolidate all Redis operations into a single pipeline to reduce network round-trips.
// This reduces round-trips from 2 to 1 for allowed requests, and 3 to 2 for blocked requests.
const pipeline = this.redis.pipeline();
pipeline.zremrangebyscore(key, 0, cutoff);
pipeline.zadd(key, now, member);
pipeline.zcard(key);
pipeline.pexpire(key, limit.windowMs);
pipeline.zrange(key, 0, 0, "WITHSCORES");
const results = await pipeline.exec();

const count = Number(results?.[2]?.[1] ?? 0);
const oldestRaw = (results?.[4]?.[1] as string[]) ?? [];
const oldest = oldestRaw.length >= 2 ? Number(oldestRaw[1]) : now;

if (count <= limit.limit) {
const oldestRaw = await this.redis.zrange(key, 0, 0, "WITHSCORES");
const oldest = oldestRaw.length >= 2 ? Number(oldestRaw[1]) : now;
return {
allowed: true,
identifier,
Expand All @@ -154,8 +158,6 @@ export class SlidingWindowRateLimiter {
}

await this.redis.zrem(key, member);
const oldestRaw = await this.redis.zrange(key, 0, 0, "WITHSCORES");
const oldest = oldestRaw.length >= 2 ? Number(oldestRaw[1]) : now;
const stableCount = Math.max(0, count - 1);
return {
allowed: false,
Expand Down
Loading