🛡️ Sentinel: [CRITICAL] Fix path traversal in LocalJsonStore#213
🛡️ Sentinel: [CRITICAL] Fix path traversal in LocalJsonStore#213hackerxj2010 wants to merge 1 commit into
Conversation
- Prevent path traversal by filtering '..' and '.' segments in keys. - Disallow absolute paths for JSON store keys. - Ensure resolved paths remain within the base directory. - Add security test suite to verify the fix. Co-authored-by: hackerxj2010 <198651211+hackerxj2010@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Path traversal in LocalJsonStore allowed unauthorized file access.
🎯 Impact: An attacker could read, write, or delete sensitive files on the server by providing a key with
..segments or absolute paths.🔧 Fix: Implemented strict key validation in
toPathmethod. It now blocks absolute paths, filters out.and..segments, and verifies that the resolved path is within the base directory.✅ Verification: New security test suite
src/security.test.tsadded and passing.PR created automatically by Jules for task 12600161609584596570 started by @hackerxj2010