Skip to content

HCK-10295: fix FE of default value for numeric types #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 1 commit into from
Mar 6, 2025
Merged

HCK-10295: fix FE of default value for numeric types #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion forward_engineering/helpers/convertJsonSchemaToAvro.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ const handleField = (name, field) => {
{
name: prepareName(name),
type: _.isArray(typeSchema.type) ? typeSchema.type : typeSchema,
default: getEnumDefaultValue(field, udt, typeSchema),
default: getDefaultValue(field, udt, typeSchema),
doc: getDoc({ field, refDescription, description }),
order,
aliases,
Expand All @@ -337,6 +337,12 @@ const getDoc = ({ field, refDescription, description }) => {
return refDescription;
};

const getDefaultValue = (field, udt, typeSchema) => {
const defaultValue = getEnumDefaultValue(field, udt, typeSchema);

return convertDefaultValueToTypeOfField(field, defaultValue);
};

const getEnumDefaultValue = (field, udt, typeSchema) => {
if (!_.isUndefined(field?.default) || typeSchema?.type === 'enum') {
return field?.default;
Expand All @@ -349,6 +355,18 @@ const getEnumDefaultValue = (field, udt, typeSchema) => {
return typeSchema?.default;
};

const convertDefaultValueToTypeOfField = (field, defaultValue) => {
if (!defaultValue) {
return defaultValue;
}

if (field.type === 'number') {
return _.toNumber(defaultValue);
}

return defaultValue;
};

const resolveFieldDefaultValue = (field, type) => {
let udtItem = _.isString(type) && getUdtItem(type);

Expand Down