Skip to content

HCK-14822: fix row filter function args parsing #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivan-m-dev merged 1 commit into from
Feb 13, 2026
Merged

HCK-14822: fix row filter function args parsing #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reverse_engineering/grammars/HiveParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ scheduleClause
;

rowClause
: KW_WITH? KW_ROW KW_FILTER functionIdentifier KW_ON (LPAREN identifier (COMMA identifier)* RPAREN)?
: KW_WITH? KW_ROW KW_FILTER functionIdentifier (KW_ON LPAREN identifier (COMMA identifier)* RPAREN)?
;

triggerOnUpdateClause
Expand Down
2 changes: 1 addition & 1 deletion reverse_engineering/parser/Hive/HiveParser.interp
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 11 additions & 11 deletions reverse_engineering/parser/Hive/HiveParser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1991,14 +1991,14 @@ const serializedATN = [
'\u0002\u0002\u0002\u0973\u0133\u0003\u0002\u0002\u0002\u0974\u0976\u0007',
'\u009c\u0002\u0002\u0975\u0974\u0003\u0002\u0002\u0002\u0975\u0976\u0003',
'\u0002\u0002\u0002\u0976\u0977\u0003\u0002\u0002\u0002\u0977\u0978\u0007',
'q\u0002\u0002\u0978\u0979\u0007\u016a\u0002\u0002\u0979\u097a\u0005',
'\u0350\u01a9\u0002\u097a\u0986\u0007%\u0002\u0002\u097b\u097c\u0007',
'q\u0002\u0002\u0978\u0979\u0007\u016a\u0002\u0002\u0979\u0986\u0005',
'\u0350\u01a9\u0002\u097a\u097b\u0007%\u0002\u0002\u097b\u097c\u0007',
'\u0175\u0002\u0002\u097c\u0981\u0005\u034e\u01a8\u0002\u097d\u097e\u0007',
'\u0173\u0002\u0002\u097e\u0980\u0005\u034e\u01a8\u0002\u097f\u097d\u0003',
'\u0002\u0002\u0002\u0980\u0983\u0003\u0002\u0002\u0002\u0981\u097f\u0003',
'\u0002\u0002\u0002\u0981\u0982\u0003\u0002\u0002\u0002\u0982\u0984\u0003',
'\u0002\u0002\u0002\u0983\u0981\u0003\u0002\u0002\u0002\u0984\u0985\u0007',
'\u0176\u0002\u0002\u0985\u0987\u0003\u0002\u0002\u0002\u0986\u097b\u0003',
'\u0176\u0002\u0002\u0985\u0987\u0003\u0002\u0002\u0002\u0986\u097a\u0003',
'\u0002\u0002\u0002\u0986\u0987\u0003\u0002\u0002\u0002\u0987\u0135\u0003',
'\u0002\u0002\u0002\u0988\u0989\u0007\u00d9\u0002\u0002\u0989\u098a\u0007',
'%\u0002\u0002\u098a\u098f\u0007\u00e9\u0002\u0002\u098b\u098c\u0007',
Expand Down Expand Up @@ -13276,12 +13276,12 @@ class HiveParser extends antlr4.Parser {
this.match(HiveParser.KW_FILTER);
this.state = 2423;
this.functionIdentifier();
this.state = 2424;
this.match(HiveParser.KW_ON);
this.state = 2436;
this._errHandler.sync(this);
var la_ = this._interp.adaptivePredict(this._input, 216, this._ctx);
if (la_ === 1) {
_la = this._input.LA(1);
if (_la === HiveParser.KW_ON) {
this.state = 2424;
this.match(HiveParser.KW_ON);
this.state = 2425;
this.match(HiveParser.LPAREN);
this.state = 2426;
Expand Down Expand Up @@ -38311,14 +38311,14 @@ class RowClauseContext extends antlr4.ParserRuleContext {
return this.getTypedRuleContext(FunctionIdentifierContext, 0);
}

KW_ON() {
return this.getToken(HiveParser.KW_ON, 0);
}

KW_WITH() {
return this.getToken(HiveParser.KW_WITH, 0);
}

KW_ON() {
return this.getToken(HiveParser.KW_ON, 0);
}

LPAREN() {
return this.getToken(HiveParser.LPAREN, 0);
}
Expand Down