Skip to content

HCK-12377: Do not format comments#159

Merged
serhii-filonenko merged 2 commits intodevelopfrom
HCK-12377
Aug 14, 2025
Merged

HCK-12377: Do not format comments#159
serhii-filonenko merged 2 commits intodevelopfrom
HCK-12377

Conversation

@Nightlngale
Copy link
Contributor

@Nightlngale Nightlngale commented Aug 14, 2025

Sub-taskHCK-12377 Do not format comments

Context

Previously, before Script generation options activation, comments were not formatted when generating DDL CREATE statements, but they were formatted for ALTER statements. Later, the logic was combined, and formatting was applied in both cases. However, this resulted in incorrect formatting for some comments (probably a bug of sql-formatter).

This PR will ignore the formatting of comments

@Nightlngale Nightlngale self-assigned this Aug 14, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Nightlngale Nightlngale marked this pull request as ready for review August 14, 2025 14:25
@serhii-filonenko serhii-filonenko enabled auto-merge (squash) August 14, 2025 14:31
@serhii-filonenko serhii-filonenko merged commit 34c3474 into develop Aug 14, 2025
9 checks passed
@serhii-filonenko serhii-filonenko deleted the HCK-12377 branch August 14, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants