Conversation
|
Homework for week3 |
epq
left a comment
epq
left a comment
There was a problem hiding this comment.
Good work so far. I've left some comments in your files.
Also, some suggestions:
- You might want to change the font family and style the links
- Since we've learned more about positioning now, you can try positioning the three images so they'll be aligned. For example, centred horizontally in a row.
- Instead of using three different font sizes for the content of your sections (20px, 30px, 25px), it would be better to stick to one font size for your main content so it's consistent.
- Since you've only used one font color (white), you could declare this in the
bodyinstead of repeating it for different elements.
| <meta name="author" content="Hamam ALsamel"> | ||
| <meta name="description" content="I am Telecom Engineer and web developer"> | ||
| <title> | ||
| <strong>Introducing Myself</strong> </title> |
| <img src="images/IMG_3872.JPG" alt="background" width="200"> | ||
| </div> | ||
|
|
||
| <nav> |
There was a problem hiding this comment.
The <nav> tag should be used for a section that provides navigation links. Since that doesn't apply to this section, you should use a <section> or <div> tag here
| background-color: rgba(70, 90, 114, 0.5); | ||
| } | ||
|
|
||
| a: hoaver{ |
There was a problem hiding this comment.
There's a typo here so the colour isn't changing when you hover over a link.
| @@ -0,0 +1,77 @@ | |||
| body{ | |||
| font-family: sans-serif; | |||
| background: url(https://cdn.pixabay.com/photo/2015/07/19/10/00/still-life-851328__340.jpg) no-repeat fixed; | |||
There was a problem hiding this comment.
It's a good idea to use an image you host yourself (i.e. an image you add to your images folder) instead of directly linking an image hosted somewhere else.
Also, the image has very small dimensions to use as a background image. It would be a good idea to choose a bigger image for the background so it's not blurry.
| <p> My name is <strong>Hamam ALsamel</strong> i am telecome engineer with 5 years experience, I have experience in two diffrent role which is electrical and telecom field, I have been in canada since 2017 and iam seeking for job in my field where I found its really difficult especially in engineering field, I join Hack Your Future because i want to learn a new thing related to Web and I found that its my interesting </p> | ||
| </header> | ||
| <section class="goals"> | ||
| <img src="https://www341.lunapic.com/editor/working/156501982863542728?7751299832" alt="dream" class="logo"> |
There was a problem hiding this comment.
This image isn't showing up because it's hot linked. You should add this image to your images folder and use it instead.
| <p>Since I have change my role in HYF I build up a new goal where i want to be qualified one program language, I have not yet decide which one until to go in depth in our course in order from me to indicate which one I prefer. My goal is to be a freelancer working in Web and making troubleshooting</p> | ||
| </section> | ||
| <div class="trip"> | ||
| <img src="images/IMG_3886.JPG" alt="background" width="200"> |
There was a problem hiding this comment.
Instead of using inline CSS, you could create a rule in your external CSS to specify the width.
| <title> | ||
| <strong>Introducing Myself</strong> </title> | ||
| <link rel="stylesheet" href="style.css"> | ||
| <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.6.3/css/all.css" integrity="sha384-UHRtZLI+pbxtHCWp1t77Bi1L4ZtiqrqD80Kn4Z8NTSRyMA2Fd33n5dQ8lWUE00s/" crossorigin="anonymous"> |
There was a problem hiding this comment.
You've included font awesome but didn't add the icons to your HTML.
2 participants
No description provided.