Adds new integration [joshburkard/home-assistant-connectivity-monitor]#6813
Adds new integration [joshburkard/home-assistant-connectivity-monitor]#6813joshburkard wants to merge 6 commits into
Conversation
|
Thank you for submitting your repository to HACS (Home Assistant Community Store). Your submission is in the review queue: You can view the current queue here. Pull requests are processed in the order they were created, oldest first. What to avoid during review:
If you need to make changes: About draft pull requests: What happens next:
|
There was a problem hiding this comment.
Hi @joshburkard, thanks for the submission! 👋
This needs a LICENSE file at the repository root before it can be added to the HACS default catalog. That's a required item per the publishing docs (https://hacs.xyz/docs/publish/start). Please pick a license (MIT, Apache 2.0, GPL, etc.), add the file at the root, and cut a new release that includes it.
One non-blocking note while you're in there: network.py _get_mac_address shells out with asyncio.create_subprocess_shell(f"{cmd} {ip}") to run arp. The arp binary often isn't present in the Home Assistant container, and shelling out for this is fragile; a non-shell approach (or dropping the MAC lookup) would be more robust. Not required for this PR.
(Note that this way of lookup is also often incorrect or inaccurate, depending on your network stack and structure).
Once the LICENSE is in place, push a new release and re-request review.
../Frenck
Blogging my personal ramblings at frenck.dev
Checklist
Links
Link to current release: https://github.com/joshburkard/home-assistant-connectivity-monitor/releases/tag/0.1.00054
Link to successful HACS action (without the
ignorekey): https://github.com/joshburkard/home-assistant-connectivity-monitor/actions/runs/24047734373/job/70135308363Link to successful hassfest action (if integration): https://github.com/joshburkard/home-assistant-connectivity-monitor/actions/runs/24047734370/job/70135308274