Refactor: Separate AutoInject from SetContainer build callback#856
Open
asdqwe02 wants to merge 1 commit into
Open
Refactor: Separate AutoInject from SetContainer build callback#856asdqwe02 wants to merge 1 commit into
asdqwe02 wants to merge 1 commit into
Conversation
|
@asdqwe02 is attempting to deploy a commit to the hadashia's projects Team on Vercel. A member of the Team first needs to authorize it. |
asdqwe02
changed the title
…ll order - change SetContainer build callback to the start of container build configuration - separate AutoInjectAll method from SetContainer and set AutoInjectAll as the last container built callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegisterBuildCallback(SetContainer)to start ofInstallTo.AutoInjectAllfromSetContainerand add to container build callback at the end ofInstallToCurrently,
SetContaineris registered as a build callback beforeInstallTois called andAutoInjectAllis call insideSetContainer, meaning user-defined container build callbacks will be called after MonoBehaviours are auto-injected via LifetimeScope.This change separate
AutoInjectAllfromSetContainerand addbuilder.RegisterBuildCallback(AutoInjectAll)to the end ofInstallTo, ensuring it is always the last registered build callback. As a result, when MonoBehaviours are auto-injected via LifetimeScope, all container build callbacks (including any registered by user installers) are guaranteed to have completed first.Before:
SetContainer(withAutoInjectAll) callback was registered before InstallTo, so it could be invoked before user-defined callbacks.After:
AutoInjectAllis separated fromSetContainer, addAutoInjectAllas last container build callback so it runs after all other build callbacks have finished.