fix: preserve deterministic direction and diff coloring in pair dedup#53
Merged
Merged
Conversation
Address code review feedback on #52: the pair dedup could render arrows in non-deterministic direction (HashSet iteration order varies) and pick the wrong diff color when the reverse direction had the change. Now prefers the direction with diff coloring (added/deleted) for accurate change visualization, and falls back to canonical (alphabetical) ordering for deterministic output across runs. Bumps version to 3.10.2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses code review feedback from #52 on the bidirectional arrow deduplication.
The previous pair dedup could:
Fix: Added
shouldSkipForReverse()that prefers the direction with diff coloring (added/deleted) for accurate change visualization, and falls back to canonical (alphabetical) ordering for deterministic output.Bumps version to 3.10.2.
Test plan
mvn clean packagesucceeds🤖 Generated with Claude Code