fix SIGSEGV at flame throughput#32
Open
x-stp wants to merge 10 commits into
Open
Conversation
x-stp
commented
Apr 19, 2026
| #include "scanner_config.h" | ||
|
|
||
| // Larger than any sane DNS/UDP response; guards against bogus mbuf data_len. | ||
| static constexpr uint16_t MAX_SANE_PKT_LEN = 4096; |
Author
There was a problem hiding this comment.
EDNS(0) support not found per issue, nor as addressed or planned for in codebase; in case of planning; may wanna bump over to 9k for Jumbo''s, or tag it in docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::get on an IPv6 reply -> bad_variant_access. Guarded it,
plus the surrounding mess:
worker: variant guard; accept any configured resolver; drop bogus
mbufs (data_len 0 or >4 KiB); re-check worker_id after ring transit;
fix spdlog format-arg miscount
dns_packet: missing break in fmt formatter; bounds-check RData
before std::span ctor
dpdk: address-of rte_ipv6_hdr::{src,dst}_addr for 25.11 ABI
cmake: PMDs are optional (looking at you, Btw)
tests: 7 regressions
// Pepijn