migrated to rematch new types#3
Open
semoal wants to merge 4 commits into
Open
Conversation
Author
|
Any suggerence mate? I'm migrating some repos that are not too much complicated to the new types to check if there's any extra issue |
Author
|
@haikyuu i hope this is not a problem to you =) |
|
1st todo: definitely 2nd todo: why we need /**
* Prepares a complete configuration and creates a Rematch store.
*/
export const init = <
TModels extends Models<TModels>,
TExtraModels extends Models
>(
initConfig?: InitConfig<TModels>
): RematchStore<TModels & TExtraModels> => {
const config = createConfig(initConfig || {})
return createRematchStore<TModels, TExtraModels>(config)
} |
Author
|
Well @haikyuu thanks for letting us rape your project a bit haha |
Owner
|
No problem, @semoal It was a pleasure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've migrated to the new types system, all of them working correctly except the testing suite that is running on a circular reference issue.