fix(review): held-note detune live-edit + EG-bias ceiling + pitch-EG trap guard (v1.18.1)#17
Merged
Conversation
…trap guard Review follow-ups to v1.17.0 (4-agent review found these): - #96: DX7Voice.applyParams reverted a held note's detune to the pitch-independent params.detune (constant +-7c) on any live param edit (snapshot version bump), so a sounding note's pitch jumped vs a freshly-struck one. Now recomputes the per-note dexedDetuneFactor, matching noteOn. - #97: the EG-bias level boost ignored the min(127, ...+klsOffset) ceiling the real env.outlevel applies, over-brightening key-scaled operators already at the OL ceiling. Now routes the boost through the same ceiling. - PitchEG.process: guard the Float->Int32 unit narrowing against a degenerate sampleRate (0/NaN) trapping on the render thread (mirrors DX7Operator.updateFreq); use kBlockSize instead of a bare 64.0. Tests: liveEditKeepsPerNoteDetune, egBiasRespectsCeiling. 255 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4-agent code review of the v1.17.0 fidelity fixes found three real defects (TDD-fixed):
DX7Voice.applyParamsreverted a sounding note's detune to the pitch-independent constant on any live param edit (snapshot version bump → applyParams on all active voices) → pitch jump vs a fresh note. Now recomputes per-notedexedDetuneFactor.min(127, …+klsOffset)ceiling → over-brightened key-scaled ops already saturated at the OL ceiling. Now routes through the same ceiling.PitchEG.processnow guards the Float→Int32unitnarrowing against a degenerate sample rate (0/NaN) trapping on the render thread.Tests:
liveEditKeepsPerNoteDetune,egBiasRespectsCeiling. 255 tests pass. Branches off v1.18.0.🤖 Generated with Claude Code