Open
Conversation
kstekovi
changed the title
kstekovi
changed the title
laDok8
reviewed
Aug 14, 2025
| @@ -0,0 +1,69 @@ | |||
| describe("TESTS: Configuration => Subsystem => Security => Settings => Global Settings", () => { | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| describe("TESTS: Configuration => Subsystem => Security => Settings => Global Settings", () => { | |
| describe("TESTS: Configuration => Subsystem => Security => Settings => Other Settings", () => { |
laDok8
reviewed
Aug 14, 2025
| const navigation = { | ||
| sslButton: "#ssl-item", | ||
| securityDomainButton: "#elytron-security-domain-item", | ||
| securityDomainRealmsButton: "#hal-uid-5", |
Collaborator
There was a problem hiding this comment.
this random number changes between version, ID shouldn't be used
laDok8
reviewed
Aug 14, 2025
| id: "elytron-security-domain-realms-add", | ||
| addButton: "elytron-security-domain-realms-table", | ||
| principalTransformer: { | ||
| id: "#elytron-security-domain-realms-add-editing > div:nth-child(2)", |
Collaborator
There was a problem hiding this comment.
there's lot of repetions of #elytron-security-domain-realms-add-editing and nth-child should be avoided for clarity if possible. Consider change like this:
laDok8
requested changes
Aug 14, 2025
| describe("TESTS: Configuration => Subsystem => Security => Settings => Global Settings", () => { | ||
| let managementEndpoint: string; | ||
|
|
||
| const address = ["subsystem", "elytron", "security-domain", "ApplicationDomain"]; |
Collaborator
There was a problem hiding this comment.
Consider extracting const securityDomainToUpdate = "ApplicationDomain";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting your Pull Request!
Please delete this text, and add a link to the public Jira issue and/or Berg issue solved by this PR, if available.
If this PR is not for the 'main' branch you must add a link to the equivalent change in 'main'.
Remember to use the Jira issue ID or Berg issue number in the PR title and any commits, if available.
Keep the title/summary of PR and any commits descriptive, so that the repository history is human readable.