Conversation
marekkopecky
force-pushed
the
hal2042-main
branch
from
3326e6a to
8d54466
Compare
OndrejKotek
reviewed
Feb 5, 2026
Comment on lines
127
to
135
| .should(($items) => { | ||
| let found = false; | ||
| for (let i = 0; i < $items.length; i++) { | ||
| const text = $items[i].innerText.trim(); | ||
| if (text.startsWith('JBoss EAP')) { | ||
| found = true; | ||
| break; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Nitpicking, I suggest to extract this as a function re-usable also in the next test, like let found = isJbossEapChannelPrinted($item).
Contributor
Author
There was a problem hiding this comment.
Thank you, updated.
OndrejKotek
approved these changes
Feb 5, 2026
marekkopecky
force-pushed
the
hal2042-main
branch
from
8d54466 to
9d379ad
Compare
marekkopecky
force-pushed
the
hal2042-main
branch
from
9d379ad to
4bfba2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for https://issues.redhat.com/browse/HAL-2042