Fixes, Changes#13
Open
csabattilas wants to merge 7 commits into
Open
Conversation
- reorganise components into feature and UI folders for better separation of concerns - implement path aliases with # prefix for cleaner imports (#ui, #components, #model, etc.) - structure state management with typed actions and action creators - implement reducer pattern with explicit action types for predictable state changes - create custom useTaskManager hook to encapsulate task-related logic and state
- generic color - generic buttons - using plugins for typo and forms - some responsiveness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Manager Fixes and Changes PR
This PR includes multiple commits. I will provide documentation detailing each commit's purpose, allowing you to review both the development process and the final outcome.
fixes, persistency and setting up unit test
This commit covers the following:
--
refactor:
This commit has a nicer more descriptive commit message
--
fix filter name
Simple bugfix for the
Newfilter--
add task name validation
Added validation for the form
I went for a simpler none-touch based validation. Only validates when trying to submit (add a new task).
--
add generic confirm dialog on task delete
Added 3rd party react-modal library to implement a modal in order to allow users to confirm deleting a task
--
boosting tailwind:
This commit meant to boost tailwind usage by:
--
add unit tests
This commit adds unit tests for
TaskItemcomponent,useTaskManagercustom hook and thetaskReducerWill downgrade the
react-iconlibrary because I think there are some typing incompatibilities. i did not dig up the reason due to short time to finish on the promised time. Downgrading solved the issues.