Skip to content

Bump golang.org/x/net from 0.35.0 to 0.55.0#308

Closed
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/golang.org/x/net-0.55.0
Closed

Bump golang.org/x/net from 0.35.0 to 0.55.0#308
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/golang.org/x/net-0.55.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 2, 2026

Copy link
Copy Markdown
Contributor

Bumps golang.org/x/net from 0.35.0 to 0.55.0.

Commits
  • 7770ec4 go.mod: update golang.org/x dependencies
  • 4ece7b6 html: escape greater-than symbol in doctype identifiers
  • 08be507 html: improve Noah's Ark clause performance
  • a8fb2fe html: properly render fostered elements in foreign content
  • 0dc5b7a html: properly check namespace in "in body" any other end tag
  • a452f3c html: ignore duplicate attributes during tokenization
  • f865199 quic: fix appendMaxDataFrame erroneously accumulating sentLimit
  • 210ed3c quic: establish a "happened-before" relationship between stream write and read
  • ad8140e quic: fix buffer slicing when handling overlapping stream data
  • 23ee2ef http2: avoid API changes when built with go1.27
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.35.0 to 0.55.0.
- [Commits](golang/net@v0.35.0...v0.55.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.55.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Jul 2, 2026
@halfrost

halfrost commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Thanks, Dependabot. Closing this one after review.

golang.org/x/net is not actually used anywhere in this module — it is a stale // indirect entry:

  • go mod why golang.org/x/netmain module does not need package golang.org/x/net
  • 0 source imports across all modules (root, template, structures, ctl/*)

So bumping it brings no functional or security benefit (the package isn't compiled into anything the repo ships or the CLI uses). Meanwhile this PR would force the module's Go directive from go 1.19 up to go 1.25.0 (required by x/net v0.55), needlessly raising the minimum Go version for what is primarily a learning/solutions repo.

The right cleanup here is go mod tidy to drop the unused indirect dependency, which I'll handle separately — not a version bump. If x/net ever becomes a real (imported) dependency, security updates will be reconsidered then.

@halfrost halfrost closed this Jul 2, 2026
@dependabot @github

dependabot Bot commented on behalf of github Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot Bot deleted the dependabot/go_modules/golang.org/x/net-0.55.0 branch July 2, 2026 23:38
@halfrost

halfrost commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Correction to my previous comment — I need to fix an inaccuracy:

golang.org/x/net is used, transitively. go mod why -m golang.org/x/net gives:

github.com/halfrost/LeetCode-Go/ctl
github.com/mozillazg/request
golang.org/x/net/proxy

i.e. the ctl scraper's HTTP client (mozillazg/request) pulls in x/net/proxy / publicsuffix. My earlier claim that it is unused and that go mod tidy would drop it was wrong — go mod tidy correctly keeps it (the plain go mod why result referred to the root package, not the sub-packages actually imported).

That said, the decision to close still stands, on accurate grounds:

  • x/net is a transitive dependency of the CLI tooling only (the LeetCode scraper), not of the solutions that this repo exists to publish.
  • The used sub-packages are proxy/publicsuffix/internal/socks; there's no untrusted-input surface here, and no reachable-vulnerability report (e.g. govulncheck) has been provided for the 0.35.0 → 0.55.0 range.
  • The PR would force the module's Go directive from go 1.19 to go 1.25.0, raising the minimum Go version for what is primarily a learning/solutions repo — too high a floor to take on for an indirect tooling dependency with no demonstrated, reachable vulnerability.

If govulncheck flags a real, reachable issue in the used paths, I'm happy to reconsider and bump just enough to resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant