Make run-clang-tidy.sh pick a default LLVM installation #8904
+61
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcourteaux
reviewed
Jan 19, 2026
| usage() { echo -e "Usage: $0 [-c]" 1>&2; exit 1; } | ||
|
|
||
| if [ "$(uname)" == "Darwin" ]; then | ||
| _DEFAULT_LLVM_LOCATION="/opt/homebrew/opt/llvm@$EXPECTED_VERSION" |
Contributor
There was a problem hiding this comment.
Would be great if you add support for MacPorts. I recently discovered macports. They are actually enabling people with older macbooks to continue working. I have a 2015 MacBook Pro, and recent LLVM versions through Homebrew are like a day worth of compiling from source. MacPorts maintains builds for older OSes, and installation is much leaner and cleaner.
mcourteaux
reviewed
Jan 19, 2026
|
|
||
| if [ "$(uname)" == "Darwin" ]; then | ||
| patch_file () { sed -i '' -E "$@"; } | ||
| _DEFAULT_LLVM_LOCATION="/opt/homebrew/opt/llvm@$EXPECTED_VERSION" |
mcourteaux
approved these changes
Jan 19, 2026
Contributor
mcourteaux
left a comment
mcourteaux
left a comment
There was a problem hiding this comment.
LGTM. I'd greatly appreciate if Halide treats the LLVM and clang installations from MacPorts as a first-class citizen.
Member
Author
If you use it, I'm happy to review/approve patches to improve support. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also applies to
run-clang-format.sh. This has been pretty aggravating for a while.