Separate the language Type from the ABI halide_type_t#9205
Open
alexreinking wants to merge 4 commits into
Open
Separate the language Type from the ABI halide_type_t#9205alexreinking wants to merge 4 commits into
alexreinking wants to merge 4 commits into
Conversation
alexreinking
force-pushed
the
alexreinking/type-exploration
branch
5 times, most recently
from
0bd2e30 to
3f1f8c9
Compare
alexreinking
commented
Jul 13, 2026
Comment on lines
+264
to
+267
| std::scoped_lock lock(handle_type_intern_mutex()); | ||
| auto &table = handle_type_intern_table(); | ||
| internal_assert(index <= table.size()) << "invalid handle-type intern index"; | ||
| return table[index - 1]; |
Member
Author
There was a problem hiding this comment.
Wondering if we need to lock here
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9205 +/- ##
=======================================
Coverage ? 70.37%
=======================================
Files ? 255
Lines ? 78617
Branches ? 18809
=======================================
Hits ? 55323
Misses ? 17742
Partials ? 5552 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexreinking
force-pushed
the
alexreinking/type-exploration
branch
3 times, most recently
from
8c26c6f to
89ab379
Compare
- ABI halide_type_t drops `lanes` -> {code, bits, reserved} (still 4 bytes;
halide_buffer_t layout unchanged). Halide::Type is decoupled and stores
its own fields; must be explicitly erased with `as_abi` (asserts scalar),
Trace event/packet carry their own `lanes`.
- Halide::Type is reduced to 8 bytes: the handle_type pointer is replaced
by a 4-byte index into a process-wide handle-type intern table.
- The IR matcher / constant folder uses Halide::Type directly; This keeps
handle C++-type metadata fidelity through matcher reconstruction.
- CodeGen intrinsic tables (ARM/X86/Hexagon/PowerPC/WebAssembly) use
Halide::Type.
- Added ostream operator<< support for halide_type_t directly.
Some open problems remain:
- d3d12 buffer element types treated as scalar (multi-channel texture format
selection is a follow-up).
- A few instances call for invalid/uninitialized `Type`s, which goes against
the overarching goal of making Type always coherent.
Fixes #9202
Fixes #9203
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alexreinking
force-pushed
the
alexreinking/type-exploration
branch
from
89ab379 to
cd20a61
Compare
Contributor
IIRC, the no-scalar buffer formats would only be applicable in specific instances of vectorized inputs/outputs. |
Member
Author
I wonder whether they actually work on |
abadams
reviewed
Jul 16, 2026
| /** Compare ordering of two types so they can be used in certain containers and algorithms */ | ||
| bool operator<(const Type &other) const { | ||
| if (type < other.type) { | ||
| if (std::tie(type_code, type_bits, type_lanes) < |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lanes-> {code, bits, reserved} (still 4 bytes; halide_buffer_t layout unchanged). Halide::Type is decoupled and stores its own fields; must be explicitly erased withas_abi(asserts scalar), Trace event/packet carry their ownlanes.Some open problems remain:
Fixes #9202
Fixes #9203
Breaking changes
The
Typeandhalide_type_targuments have been significantly reworked. This is both an ABI and an API break.Checklist