Skip to content
This repository was archived by the owner on Apr 21, 2026. It is now read-only.

Various fixes and improvements#57

Open
kmecpp wants to merge 10 commits into
halvors:1.7.10from
VoltzModpack:1.7.10
Open

Various fixes and improvements#57
kmecpp wants to merge 10 commits into
halvors:1.7.10from
VoltzModpack:1.7.10

Conversation

@kmecpp

@kmecpp kmecpp commented Sep 20, 2018

Copy link
Copy Markdown
Collaborator

I will do more work on Quantum Assemblers but didn't have time to fix all the issues with BlockPos, which wasn't being loaded on readFromNBT.

To fix combining turbines and and some other issues, I stopped it from being cached in BaseTile. However, when you login, the packets don't send immediately. I wasn't sure how else to fix that so I lowered the packet transfer update rate in TileElectricTurbine. it looks better but I feel like there should be a better fix.

Water still doesn't boil though and I'm not sure why

@halvors

halvors commented Sep 24, 2018

Copy link
Copy Markdown
Owner

@kmecpp Thanks for your contribution, there's only one problem. Nuclear Physics does all change to 1.10.2 branch, and backports those changes to 1.7.10. For 1.7.10 specific issues it should be changed on the 1.7.10 branch, but for general fixes and changes those should be made on the 1.10.2 branch.

There's many great changes and fixes here, very good work :) But for the reasons mentioned above, i'd have to apply this PR manually on the 1.10 branch, and the 1.7 specific on the 1.7 branch.

I'll do this when i have some spare time, i'll of course give you credit :)

But keep in mind for next time, try to target 1.10 branch when sending pull request, if it's not 1.7.10 specific code.
The fixing of BlockPos thing is surely something to target 1.7.10 for :)

Thank you very much, i'll consider giving you access directly to this GIT respository at a later time.

@halvors halvors self-assigned this Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants