Fix whitespace control for chained blocks#19
Open
zygzagZ wants to merge 1 commit intohandlebars-lang:masterfrom
Open
Fix whitespace control for chained blocks#19zygzagZ wants to merge 1 commit intohandlebars-lang:masterfrom
zygzagZ wants to merge 1 commit intohandlebars-lang:masterfrom
Conversation
omitLeft failed for helper ending block in chained inverse. It tried to omitLeft whitespace only for the first inverse, which is incorrect.
Failing scenario:
```
{{#if false}}
{{else if false}}
{{else}}
{{/if}}
```
TAB used to make it into the template.
WhitespaceControl failed to omit tab character, while working properly on a bit simpler scenario:
```
{{#if false}}
{{else}}
{{/if}}
```
Here, TAB did not use to make it into the template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omitLeft failed for helper ending block in chained inverse. It tried to omitLeft whitespace only for the first inverse, which is incorrect. Failing scenario:
TAB used to make it into the template.
WhitespaceControl failed to omit tab character, while working properly on a bit simpler scenario:
Here, TAB did not use to make it into the template.
This PR fixes first scenario to also omit tab.