fix: After the the thing builds#21
Closed
MichalBryxi wants to merge 1 commit intohandlebars-lang:masterfrom
Closed
fix: After the the thing builds#21MichalBryxi wants to merge 1 commit intohandlebars-lang:masterfrom
MichalBryxi wants to merge 1 commit intohandlebars-lang:masterfrom
Conversation
NullVoxPopuli
requested changes
Apr 15, 2025
Contributor
NullVoxPopuli
left a comment
There was a problem hiding this comment.
removing type=module changes the interpretation of .js
instead, you may want to change the build to emit cjs for the package.json#exports require condition
it looks like those files don't end in .cjs, as they should.
but more importantly, what error are you trying to fix?
Author
Repro is in |
Author
|
After the discussion with @NullVoxPopuli, I think the most productive path that wastes least amount of time would be to document the node requirements and move on?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhere between
v2.1.0andv2.2.0this package started having issues withember-cli-addon-docs. This patch fixes that.Fixes: #20
With this change I can remove the override from
ember-intlspakcage.json:"pnpm": { "overrides": { - "ember-cli-addon-docs>@handlebars/parser": "2.1.0" + "ember-cli-addon-docs": "file:../ember-cli-addon-docs", // points to `v2.2.0` version of the addon + "ember-cli-addon-docs>@handlebars/parser": "file:../handlebars-parser" // points to my fix } }And
ember-intladdon docs boot up correctly.