Add a react extension that tracks transactions#3
Merged
smoores-dev merged 1 commit intomainfrom Aug 26, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, so here are the constraints we're under:
This means that in order to keep the EditorView in sync with the lifted EditorState, we must track the set of transactions that has been applied to the lifted EditorState, and apply them to the EditorView's state.
To accomplish this, we introduce a new
reactextension that has a StateField that literally just accumulates a list of transactions that it sees. The useEditor hook then pulls those transactions out of that StateField and applies them to the view's state.In order to avoid applying the same transaction multiple times, we keep a set of transactions that we've already seen, and filter them out of the StateField. This ought to be safe — Transactions must be based on the EditorState they're being applied to, so it's impossible to dispatch the same transaction instance twice (they would have to have different state bases).
This is a breaking change!