Open
Conversation
yotamshalev
reviewed
Apr 12, 2023
Contributor
yotamshalev
left a comment
yotamshalev
left a comment
There was a problem hiding this comment.
Let's try to always resolve one issue in each PR. this will make the reviewers work easier since they will know that every change is related to what you're solving.
It's fine to make several changes in a single PR if the changes are very small.
| {showNotValidName && ( | ||
| <> | ||
| <div className="darken"></div> | ||
| <Popup |
Contributor
There was a problem hiding this comment.
I think a more correct implementation of the popup would be to locate it within the App component and expose an API which allows to open it from any of the app's pages.
| phoneNumber: "", | ||
| day: "", | ||
| hourRange: "", | ||
| selectedDays: [], |
Contributor
There was a problem hiding this comment.
can we wait with this change for the next PR?
- I think we need some more changes here
- I want this related PR to be merged first:
Write to air table #15
Collaborator
Author
There was a problem hiding this comment.
So for now should I leave it?
Issue #27 also requires us to change another field from string to array, wait with it too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Reviewer
Related Issue
#12 , #15 , #20
Please Review