Open
Conversation
yotamshalev
reviewed
Apr 18, 2023
|
|
||
| dispatch( | ||
| openPopup({ | ||
| title: "מעולה! פרטייך נשלחו", |
Contributor
There was a problem hiding this comment.
texts here are not correct. should be a text that's asking the user to confirm to post the session request
| title: "מעולה! פרטייך נשלחו", | ||
| text: "בקרוב ניצור איתך קשר בוואטסאפ ונקשר אותך לשיחה עם אדם עם תחושות שונות בנושא שבחרת", | ||
| handleConfirm: () => { | ||
| postSessionRequest(session); |
Contributor
There was a problem hiding this comment.
Suggested change
| postSessionRequest(session); | |
| try { | |
| await postSessionRequest(session); | |
| // close popup and redirect to a success page (not back to emotions selection) | |
| } catch(error) { | |
| // handle network request error by displaying an error to the user | |
| } | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Reviewer
Related Issue
Please Review