Skip to content

Propose strategy for dealing with color flags #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wswoodruff wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Propose strategy for dealing with color flags #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed65e87
Propose strategy for dealing with color flags
wswoodruff Jul 27, 2020
bf87eaf
Remove package-lock
wswoodruff Jul 27, 2020
db1dfe8
Refactor
wswoodruff Aug 7, 2020
e7ed5a0
Cleanup
wswoodruff Aug 7, 2020
a236d33
Remove metaFlags stuff, add timeouts to 2 possibly slow tests
wswoodruff Jan 29, 2021
18f6a09
rm package-lock
wswoodruff Jan 29, 2021
7d8080b
Merge branch 'master' into color-and-no-color-flags
wswoodruff Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,16 @@ internals.definition = {
alias: 'l',
description: '[run] lists all available commands on your server',
default: null
},
color: {
type: 'boolean',
description: '[*] sets output to use color',
default: null
},
'no-color': {
type: 'boolean',
description: '[*] sets output to not use color',
default: null
}
};

Expand Down
4 changes: 2 additions & 2 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,7 +1173,7 @@ describe('hpal', () => {
expect(result.errorOutput).to.contain('Sorry, couldn\'t find documentation for "xxx".');
});

it('fetches docs from the packages\'s master branch when in a project that does not use the package.', async (flags) => {
it('fetches docs from the packages\'s master branch when in a project that does not use the package.', { timeout: 3000 }, async (flags) => {

const mockWreck = mockWreckGet(null);
flags.onCleanup = mockWreck.cleanup;
Expand All @@ -1189,7 +1189,7 @@ describe('hpal', () => {
expect(result.errorOutput).to.contain('Sorry, couldn\'t find documentation for "xxx".');
});

it('fetches docs for the version specified by [--ver].', async (flags) => {
it('fetches docs for the version specified by [--ver].', { timeout: 3000 }, async (flags) => {

const mockWreck = mockWreckGet(null);
flags.onCleanup = mockWreck.cleanup;
Expand Down