Skip to content

chore: trim .fallowrc (fallow 2.84.0 handles these natively) #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BartWaardenburg wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

chore: trim .fallowrc (fallow 2.84.0 handles these natively) #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e75302
chore: trim .fallowrc now that fallow 2.84.0 handles these natively
BartWaardenburg May 28, 2026
901dc1a
chore: bump fallow script pins 2.62.0 -> 2.84.0 to match the trimmed …
BartWaardenburg May 28, 2026
0b49939
test: sync fallow wiring guard with trimmed config
BartWaardenburg May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions .fallowrc.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"$schema": "https://raw.githubusercontent.com/fallow-rs/fallow/main/schema.json",
"entry": [
"vitest.config.ts",
"apps/*/app.config.{js,ts}",
"apps/*/babel.config.{js,cjs,mjs,ts}",
Comment on lines 1 to 5

@greptile-apps greptile-apps Bot May 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Config trimmed for 2.84.0 but scripts still pin 2.62.0

All three removals rely on features not present in fallow 2.62.0: @*/__mocks__ virtual-specifier credits landed in 2.63.0, node:sqlite builtin recognition in 2.81.0, and feature-flags defaulting to off in 2.84.0. Because package.json pins every fallow script to npx --yes fallow@2.62.0, anyone running npm run fallow (or the CI lane) will get the old 2.62.0 binary, which lacks those native behaviors and will surface the removed entries as findings again. The version pin in package.json needs to be bumped to at least 2.84.0 alongside this config change, otherwise the two are inconsistent.

"apps/*/metro.config.{js,cjs,mjs,ts}",
Expand Down Expand Up @@ -34,21 +33,6 @@
"packages/tests/playwright-report/**",
"packages/tests/test-results/**"
],
"ignoreDependencies": [
"@elevenlabs/__mocks__",
"@expo/__mocks__",
"@happier-dev/__mocks__",
"@huggingface/__mocks__",
"@pierre/__mocks__",
"@playwright/__mocks__",
"@react-native-async-storage/__mocks__",
"@react-navigation/__mocks__",
"@sentry/__mocks__",
"@shopify/__mocks__",
"@socket.io/__mocks__",
"@xterm/__mocks__",
"node:sqlite"
],
"duplicates": {
"ignoreImports": true,
"ignore": [
Expand All @@ -70,8 +54,5 @@
},
"audit": {
"gate": "new-only"
},
"rules": {
"feature-flags": "off"
}
}
18 changes: 9 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@
"tailscale:disable": "node ./apps/stack/scripts/repo_local.mjs tailscale disable",
"tailscale:url": "node ./apps/stack/scripts/repo_local.mjs tailscale url",
"env": "node ./apps/stack/scripts/repo_local.mjs env",
"fallow": "npx --yes fallow@2.62.0",
"fallow:changed": "npx --yes fallow@2.62.0 audit --base origin/dev",
"fallow:changed:json": "npx --yes fallow@2.62.0 audit --base origin/dev --format json --quiet",
"fallow:dead": "npx --yes fallow@2.62.0 dead-code",
"fallow:dupes": "npx --yes fallow@2.62.0 dupes",
"fallow:health": "npx --yes fallow@2.62.0 health",
"fallow:fix:dry": "npx --yes fallow@2.62.0 fix --dry-run",
"fallow:baseline:save": "node -e \"require('fs').mkdirSync('.fallow',{recursive:true})\" && npx --yes fallow@2.62.0 --save-regression-baseline .fallow/regression-baseline.json",
"fallow:baseline:check": "npx --yes fallow@2.62.0 --fail-on-regression --regression-baseline .fallow/regression-baseline.json",
"fallow": "npx --yes fallow@2.84.0",
"fallow:changed": "npx --yes fallow@2.84.0 audit --base origin/dev",
"fallow:changed:json": "npx --yes fallow@2.84.0 audit --base origin/dev --format json --quiet",
"fallow:dead": "npx --yes fallow@2.84.0 dead-code",
"fallow:dupes": "npx --yes fallow@2.84.0 dupes",
"fallow:health": "npx --yes fallow@2.84.0 health",
"fallow:fix:dry": "npx --yes fallow@2.84.0 fix --dry-run",
"fallow:baseline:save": "node -e \"require('fs').mkdirSync('.fallow',{recursive:true})\" && npx --yes fallow@2.84.0 --save-regression-baseline .fallow/regression-baseline.json",
"fallow:baseline:check": "npx --yes fallow@2.84.0 --fail-on-regression --regression-baseline .fallow/regression-baseline.json",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
"ci:act": "bash scripts/ci/run-act-tests.sh",
"test": "yarn -s test:unit",
"test:unit": "yarn workspace @happier-dev/protocol test && yarn workspace @happier-dev/transfers test && yarn workspace @happier-dev/agents test && yarn workspace @happier-dev/cli-common test && yarn workspace @happier-dev/connection-supervisor test && yarn workspace @happier-dev/bootstrap test && yarn workspace @happier-dev/app test && yarn workspace @happier-dev/cli test:unit && yarn --cwd apps/server test:unit && yarn --cwd packages/relay-server test && yarn --cwd apps/stack test:unit",
Expand Down
4 changes: 1 addition & 3 deletions scripts/testing/lib/fallowLocalTooling.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ type PackageJson = Readonly<{
type FallowConfig = Readonly<{
$schema?: string;
entry?: readonly string[];
ignoreDependencies?: readonly string[];
duplicates?: Readonly<{
ignoreImports?: boolean;
}>;
Expand All @@ -18,7 +17,7 @@ type FallowConfig = Readonly<{
}>;
}>;

const FALLOW_VERSION = '2.62.0';
const FALLOW_VERSION = '2.84.0';

function readJsonFile<T>(path: string): T {
assert.equal(existsSync(path), true, `${path} must exist`);
Expand Down Expand Up @@ -55,6 +54,5 @@ test('Fallow config is checked in while generated local state stays ignored', ()
assert.equal(config.duplicates?.ignoreImports, true);
assert.ok(config.entry?.includes('scripts/**/*.{js,mjs,cjs,ts,tsx}'));
assert.ok(config.entry?.includes('apps/*/scripts/**/*.{js,mjs,cjs,ts,tsx}'));
assert.ok(config.ignoreDependencies?.includes('node:sqlite'));
assert.match(gitignore, /^\/\.fallow\/$/m);
});