Open
Conversation
beforeClose beforeOpen afterClose afterOpen triggered even if the isVisible state was unchanged while the component received an update. Now the change of isVisible before and after the Update will be compared.
improved open and close detection
* Move .babelrc and .eslintrc to package.json to clean up top-level dir. * Break core functionality into 'SkyLightStateless' component, which can be used in Flux contexts. Update SkyLight component to thunk its internal state to the SkylightStateless props. * Add Module entrypoint file (index.js) so that clients can optionally pick up SkyLight stateles. SkyLight is still the default export. * Use AirBnb's eslint configuration to eliminate some boilerplate.
…ul for better Coverage Report
Polyfill Object.assign()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.