Conversation
don't manually try to use cached data! That doesn't work well, introduces unnecessary complexity!
Fix Tanstack for Workspace
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential benefits of this PR:
But I might have also broken some things that I'm not aware of yet, and maybe made some things (some data fetching, maintainability, ...) worse overall 😓
==> I am not convinced myself whether the changes are net positive. We should only a) review this after testing at least some of the improved functionality and saying the functionality is better (mainly summary update status indication and auto update triggers); and b) if then the code review is also positive.
Also note that it will be possibly much easier reviewing all the changes together, instead of commit by commit; because I made some u-turns / replaced some implementations with others with others... 🥵
High-level technical overview of the main changes I did:
Note: There might actually be better ways to achieve updating the summary when there are changes, e.g. there seems to be something like 'Logical Replication' which let's you subscribe to database changes. I wasn't aware of this before doing all this refactor.